Skip to content

GitLab

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Closed (moved)
Created by Mike Perry@mikeperry

Verify that new DOM properties are really disabled

In https://lists.torproject.org/pipermail/tor-qa/2015-August/000667.html, boklm notes:

We have the following DOM objects that were not present in esr31:

onlanguagechange, mozRequestOverfill, back, forward, home, openDialog,
controllers, realFrameElement, MozSelfSupport, _content, Symbol,
WeakSet, HTMLPictureElement, AnimationEffect, PerformanceMeasure,
PluginCrashedEvent, MenuBoxObject, ScrollViewChangeEvent,
SelectionStateChangedEvent, DOMMatrixReadOnly, DOMMatrix,
PopupBoxObject, AnimationTimeline, PerformanceMark, DOMApplication,
IDBMutableFile, StereoPannerNode, CameraDetectedFace,
CameraStateChangeEvent, CSSCounterStyleRule, CameraRecorderVideoProfile,
CameraRecorderProfile, CameraRecorderProfiles, AnonymousContent,
NamedNodeMap, DOMApplicationsManager, ContentProcessMessageManager,
CameraConfigurationEvent, HTMLAllCollection, PromiseDebugging,
SubtleCrypto, Animation, CameraRecorderAudioProfile, RadioNodeList,
WindowRoot, CameraClosedEvent, CryptoKey, CameraFacesDetectedEvent,
MozSettingsTransactionEvent, IDBFileRequest, BroadcastChannel,
MessageChannel, AnimationPlayer

Some of those should have been disabled by various prefs we have set (in particular PerformanceMeasure, PerformanceMark, and the IDB objects). We should look into that. Hopefully they are just empty placeholders. Also, the camera stuff should have been compiled out and also disabled via the peerconnection prefs, I thought.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information