Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #1684

Closed (moved)
Open
Opened Jul 10, 2010 by Peter Eckersley@pde

HTTPS Everywhere: Aborting possible favicon [IMAGE], should be HTTPS!

Certain correctly-written rulesets cause this error message to appear frequently in the Error Console. We believe the bug may simultaneously randomly prevent the image from rendering.

The bug is caused by a race condition between the favicon abort code we borrowed from NoScript, and the nsIContentPolicy codepath. The favicon abort code unfortunately appears to be necessary in order to prevent frequent crashes from an underlying Firefox bug.

There may be some workaround we can implement by tightening the favicon heuristics in replaceChannel(). But until that has been demonstrated and tested, we will have to avoid shipping rules that trigger the error frequently. You can keep using them privately, but they will occasionally prevent some image from rendering.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#1684