Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #16849

Closed (moved)
Open
Opened Aug 18, 2015 by teor@teor

clear_status_flags_on_sybil might want to clear more flags

clear_status_flags_on_sybil contains a comment saying "it's easy to add a new flag but forget to add it to this clause."

It looks like we may have forgot the following flags:

  • is_hs_dir
  • version_known?
  • version_supports_extend2_cells?
  • has_bandwidth
  • has_exitsummary?
  • bw_is_unmeasured? (set to 1?)
  • bandwidth_kb
  • has_guardfraction
  • guardfraction_percentage

To deal with the root cause, should we instead zero out the entire routerstatus_t, then copy the fields we need back in? (This would zero new fields on sybils by default.)

We could also implement a unit test for clear_status_flags_on_sybil that checks that certain (important?) flags are cleared, or that all flags are cleared (?).

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#16849