Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #17404

Closed (moved)
(moved)
Open
Created Oct 21, 2015 by Nick Mathewson@nickm🍬

dn_indicates_v3_cert can call memcmp up to 4 chars before the beginning of a string.

dn_indicates_v3_cert() does this:

  len = ASN1_STRING_to_UTF8(&s, str);
  if (len < 0) {
    return 0;
  }
  r = fast_memneq(s + len - 4, ".net", 4);

Note that if the len < 4, we read bytes from a malloc header, which isn't a good thing at all.

In practice, I don't think this should cause crashes or security failures, unless somebody is using a very weird malloc, or unless somebody has a hardened installation that detects this kind of invalid check.

Still, this is a must-fix.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking