Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #17634

Closed (moved)
(moved)
Open
Created Nov 18, 2015 by Georg Koppen@gk

Be more strict if applying double quotes around passwords

When authenticating we handle the control password as follows:

// Surround non-hex strings with double quotes.
const kIsHexRE = /^[A-Fa-f0-9]*$/;
if (!kIsHexRE.test(pwdArg))
pwdArg = '"' + pwdArg + '"';

But the spec says "AUTHENTICATE" [ SP 1*HEXDIG / QuotedString ] CRLF and HEXDIG being DIGIT / "A" / "B" / "C" / "D" / "E" / "F" according to RFC 2234. Thus, we are a bit more lenient than we should at the moment.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking