Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #17684
Closed (moved) (moved)
Open
Issue created Nov 25, 2015 by teor@teor

Simplify directory_get_from_dirserver so it can be unit tested

In #4483 (moved), I refactor directory_get_from_dirserver so it can be unit tested.

But there's a series of stubborn nested conditionals in the middle of the function, that also change the values they're checking.

If we simplified this knot of conditions, then it would be much easier to unit test.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking