Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #17724

Closed (moved)
Open
Opened Nov 30, 2015 by cypherpunks@cypherpunks

Unreliable rend_cache_purge test

The test_rend_cache_purge function contains an assertion which verifies that the internal strmap does not change after a purge (src/test/test_rendcache.c:1044 on 0a701e537778ac9da31049f4efebf7cb2bf9c285).

However, the rend_cache_purge function frees the internal strmap and allocates a new one. This turns the assertion in a check whether memory allocation returns the same address as was just freed. The C11 standard mentions that a previous call to free is synchronized with a call to malloc [0].

I found the issue during a Valgrind run which probably changed the behavior of free and malloc to track them and caused the assertion to fail.

I am suggesting to remove the assertion because it verifies behavior that does not affect normal operation and (in my case) interferes with testing.

[0] [http://en.cppreference.com/w/c/memory/malloc]

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.2.8.x-final
Milestone
Tor: 0.2.8.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#17724