Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #17751

Closed (moved)
Open
Opened Dec 04, 2015 by teor@teor

Use router_get_my_routerinfo() rather than desc_routerinfo

The following functions use desc_routerinfo where they could use router_get_my_routerinfo():

  • check_descriptor_ipaddress_changed
  • router_compare_to_my_exit_policy
  • router_my_exit_policy_is_reject_star
  • router_get_my_descriptor
  • check_descriptor_bandwidth_changed

This could cause issues if desc_routerinfo needs to be rebuilt, because some of these functions don't call router_get_my_routerinfo() first.

Others have comments about desc_routerinfo that might need to be updated:

  • dirserv_get_routerdescs
  • router_compare_to_my_exit_policy
    • Also change "IPv6 and IPv6 entries" to "IPv4 and IPv6 entries"
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.2.9.x-final
Milestone
Tor: 0.2.9.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#17751