Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #17830

Closed (moved)
(moved)
Open
Created Dec 12, 2015 by iwakeh iwakeh@iwakeh

use StringBuilder correctly

This is not java 7 related, but should be included here:

Code like this

 crypto = new StringBuilder();
 crypto.append(line + "\n");

defeats the purpose of using StringBuilder, because String concatenation using + will internally be accomplished by using another StringBuilder (see Javadoc).

This should also be added to the coding guidelines (or did we write these for Onionoo only?).

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking