Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #17876

Closed (moved)
(moved)
Open
Created Dec 16, 2015 by Nick Mathewson@nickm🍬

Connection_ap_about_to_close should call connection_edge_about_to_close.

In a2ad31a92, we split connection_about_to_close into separate functions. And we made connection_edge_about_to_close hold the common logic for AP_CONN and EXIT_CONN. But... we never made connection_ap_about_to_close call connection_edge_about_to_close!

This should be harmless in 0.2.7 and earlier, since all connection_edge_about_to_close does is (possibly) generate a warning. But In 0.2.8 for #17590 (moved), we shoved a bunch of code in connection_edge_about_to_close that really does matter, for entry connections that are pending circuits.

Bug in 0.2.3.2-alpha.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking