Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #17893

Closed (moved)
(moved)
Open
Created Dec 18, 2015 by cypherpunks@cypherpunks

Stop building and testing Tor twice when running distcheck

In commit 9f6b9e28ccfdc3a96fb6e28d5121539f3cba3c55 the steps for putting out a new Tor release changed from running make check to make distcheck. With this change there is no need for the dist rule in Makefile.am:76 anymore.

The rule causes Tor to be built and tested twice when make distcheck is called (once in the current build directory and other time in the temporary distcheck build directory). This is caused by the distcheck rule calling our dist rule which calls the internal check rule which triggers the all rule.

The removal would make the workflow of testing build configuration changes faster (especially on slower machines) by not having to wait on the first compilation and testing phase which is performed by distcheck anyway.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking