Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #17893

Closed (moved)
Open
Opened Dec 18, 2015 by cypherpunks@cypherpunks

Stop building and testing Tor twice when running distcheck

In commit 9f6b9e28ccfdc3a96fb6e28d5121539f3cba3c55 the steps for putting out a new Tor release changed from running make check to make distcheck. With this change there is no need for the dist rule in Makefile.am:76 anymore.

The rule causes Tor to be built and tested twice when make distcheck is called (once in the current build directory and other time in the temporary distcheck build directory). This is caused by the distcheck rule calling our dist rule which calls the internal check rule which triggers the all rule.

The removal would make the workflow of testing build configuration changes faster (especially on slower machines) by not having to wait on the first compilation and testing phase which is performed by distcheck anyway.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.2.8.x-final
Milestone
Tor: 0.2.8.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#17893