Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #18112

Closed (moved)
Open
Opened Jan 20, 2016 by cypherpunks@cypherpunks

TorButton logs + Tor logs = timezone leak

TorButton messages are timestamped with UTC time, Tor's with local time. In combination the logs leak the user's timezone, free of context. (Tor alone might leak the timezone depending on context.)

Sample (here the timezone would be GMT+5):

[01-18 01:14:04] Torbutton DBUG: Got timer update, but no cookie change.
Jan 18 06:14:30.000 [notice] Tried for 120 seconds to get a connection to [scrubbed]:80. Giving up.

Also the formats don't match. The first is preferred, the second further leaks the locale language.

Preferably, Tor should use UTC timestamps (perhaps controlled with a torrc setting, see #15607 (moved)) and numeric months.

As a temporary workaround, perhaps TorLauncher should set TZ to :UTC (similar to TorButton, but see also #16622 (moved)) before spawning Tor.

Also, in relation to the discussion in #15607 (moved): Logs are not API! Let stupid programs break if necessary.

Tor Browser: 5.0.7 Tor: 0.2.7.6 TorLauncher: 0.2.7.7 TorButton: 1.9.3.7

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#18112