Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #18306
Closed (moved) (moved)
Open
Issue created Feb 12, 2016 by teor@teor

Avoid using tor_assert before the logging system is fully initialised

In #18241 (moved), we discovered that an assertion failure that occurs before or during the initialisation of the logging system causes an infinite loop.

We need to check tor and the tools for these kinds of issues.

In particular, the logging system initialises the log mutex. tor_mutex_init() can still call tor_assert if it fails, so the possibility of this stack overflow still exists when we're initialising the log mutex itself.

Now these kinds of failures don't happen very often, and if they do, it's unlikely tor would ever launch. But it would be better to use fprintf(stderr, ...); in these circumstances so that users can see the actual log message.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking