dir auths vote "package" lines out of order
In proposal 227, we say
Votes and consensuses may include any number of "package" lines, but no vote or consensus may include more than one "package" line with the same PACKAGENAME and VERSION values. All "package" lines must be sorted by "PACKAGENAME VERSION", in lexical (strcmp) order.
but I just had moria1 set up its torrc with
RecommendedPackages shouldbesecond 0 http digest=digest RecommendedPackages outoforder 0 http digest=digest
and sure enough, its vote now says
package shouldbesecond 0 http digest=digest package outoforder 0 http digest=digest
I've looked through the code, and it looks like the lines do get sorted for the consensus. And maybe there is no problem with having them unsorted in the votes? In that case should we just update the proposal document so future me doesn't get confused? Or, better, should we change votes to sort them too, because it can't hurt and it might help?