Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #18901

Closed (moved)
(moved)
Open
Created Apr 26, 2016 by Nick Mathewson@nickm🍬

Should we stop appling --enable-expensive-hardening to constant-time code ?

The ubsan and asan options introduce branch instructions all over the place. Although these branches are never actually taken in by code that doesn't immediately crash, I'm concerned that they might make our constant-time code less constant-time, with a suitably weird branch predictor.

(I have no evidence that this is actually happening, but the whole situation is a confusing mess.)

Out of an abundance of caution, I'd suggest that we make those options apply only to the non-constant-time code

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking