The tor_parse_* functions should check and warn on max < min
If a developer mistakenly calls:
tor_parse_long(value, 10, 1, UINT32_MAX, NULL, NULL);It effectively becomes:
tor_parse_long(value, 10, 1, -1, NULL, NULL);We can detect this by making sure min <= max, and warning if that's not the case. (I really don't think we should assert.)
We should do this for all similar tor_parse_* functions.
But are there any circumstances where we should allow min to be greater than max? (it will always fail) Existing callers pass constants to this function, so it's not going to trigger for them.
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information