Skip to content

GitLab

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Closed (moved)
Opened by Nick Mathewson@nickm🐭

libscrypt check fails when libscrypt requires libm

See #19161 (moved) for background.

When libscrypt requires libm, our current check fails to detect libscrypt. This caused a failure to build (#19161 (moved)), which we fixed by not calling libscrypt_scrypt() unless that function was actually found.

But we still have a problem here: We would like to detect libscrypt in these cases, and actually use it as appropriate.

Isis and I wrote a solution in isis's branch bug19161_028, but it has some remaining infelicities, I think. Will transcribe those in a comment.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information