Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #19195

Closed (moved)
(moved)
Open
Created May 28, 2016 by teor@teor

[prop250] Remove unnecessary assertion in sr_compute_srv

In dgoulet's srv-testing-2, git 0234595:

In sr_compute_srv, this doesn't make much sense:

uint64_t reveal_num;
...
tor_assert(reveal_num < UINT64_MAX);

Why stop reveal_num being equal to UINT64_MAX? There's absolutely no harm in it being equal.

Let's just delete the condition. (Or provide a comment saying why we're checking.)

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking