Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #1933

Closed (moved)
Open
Opened Sep 13, 2010 by Damian Johnson@atagar

GETINFO requests trigger conn_read_callback events

GETINFO requests are triggering the following DEBUG runlevel events: "conn_read_callback(): socket 15 wants to read.". Is this intentional?

This traces back to the 'connection_add' function of 'or/main.c', but after that the callers branch quite a bit so I'm not sure how it's connected to the control interface.

This causes a minor interface problem for arm since key presses trigger GETINFO calls but also are used to scroll the event log (ie, when the user presses 'up' at the DEBUG level it both scrolls up an entry and creates a new event, so they'll never get to the top).

This issue will partly go away when I refactor the connection panel to be independent of the main interface loop, but it still means arm and other controllers issuing periodic GETINFO calls are kinda noisy at the DEBUG level (accounting for instance triggers four GETINFO requests every ten seconds for accounting/* updates) so it would be nice if this was changed. However, if this is working as intended then I should probably filter these events out of the arm interface.

Tor version 0.2.2.13-alpha (oddly, this isn't among the version options...). Cheers! -Damian

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#1933