Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #19379

Closed (moved)
(moved)
Open
Created Jun 11, 2016 by Nick Mathewson@nickm🍬

Consider adding even more compiler warnings, even when they require code changes.

Some of these warnings might be worth adding, either globally or selectively, but they would require a significant amount of effort to modify our code. (I already got the easy cases with #19180 (moved), I think.)

  cast-qual (4.6)

    Rationale: triggers everywhere, even in some pretty normal C.  Would
    be nice to have it trigger less, but would need to blow up a bunch
    of API things.  Bigger project.

  conversion (4.6)

    Rationale: triggers all over.  Probably wrong code in some
    cases, but careful thought needed in most Bigger project.

  sign-conversion (4.6)

    Triggers ALL OVER.  Quite possibly a bug in some cases, though.
    Bigger project.

  cast-align (3)
    We already do this safely. Need to re-test on a system with
    stronger-than-intel alignment rules, though.

  shadow (3)
    mistake; worth fixing.

  switch-default (3)
   Not sure this is a good idea; someof these look like mistakes,
   but some don't.

  assign-enum (clang)
   triggers all over; worth fixing.

  conditional-uninitialized (clang)
   triggers all over; not sure whether this is worth fixing.
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking