Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #20107

Closed (moved)
Open
Opened Sep 08, 2016 by Trac@tracbot

somthings wrong about function channel_get_actual_remote_address()

description

function channel_get_actual_remote_address is written to get the ip address of a channel, but when we use it in function command_process_created_cell, we find that it get the same ip address about circ->n_chan and TO_OR_CIRCUIT(circ)->p_chan. But actually they have different ip address because TO_OR_CIRCUIT(circ)->p_chan is not equals to circ->n_chan, and TO_OR_CIRCUIT(circ)->p_circ_id is not equals to circ->n_circ_id.

test

If you want to check whether I am right, you can add this code into the last line in function command_process_created_cell, the funtion is written in the file command.c. I have check it in tor-0.2.8.7 and tor-0.2.7.6.

log_notice(LD_GENERAL, "p_ip_addr:%s, p_circ_id:%u, n_ip_addr:%s, n_circ_id:%u",
                channel_get_actual_remote_address(TO_OR_CIRCUIT(circ)->p_chan),
                TO_OR_CIRCUIT(circ)->p_circ_id,
                channel_get_actual_remote_address(circ->n_chan), 
                cell->circ_id);

Trac:
Username: DLP_ripper

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#20107