Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #20277

Closed (moved)
(moved)
Open
Created Oct 02, 2016 by Roger Dingledine@arma

Confusing "Not all bridges handle conditional consensus downloading" comment

There's this comment in directory.c:

      /* XXX+++++ Not all bridges handle conditional consensus downloading,
       * so, for now, never assume the server supports that. -PP
       * Is that assumption still so in 2016? -NM */

And you're right, the conditional consensus stuff has been in since Tor 0.2.1.x.

So I went to go rip out the special-casing code, but it already got ripped out in git commit 7988596f (which went into Tor 0.2.4.2-alpha).

And then, inexplicably, I seem to have added the stanza back in during git commit a8297cdbd3 (which went into Tor 0.2.4.11-alpha).

I just looked around at the code some more and I'm now convinced that indeed that code is gone. We should fix the comments.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking