Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #20337

Closed (moved)
Open
Opened Oct 11, 2016 by Yawning Angel@yawning

Support abstract namespace AF_UNIX sockets.

Linux has a notion of abstract AF_UNIX sockets. This should be supported both for the control and socks port, as they are convenient and useful, as long as they are used correctly.

Benefits:

  • Easier to bundle. sun_path length limitations are dumb, being able to use an abstract identifier is simpler.
  • No need to mess around with creating a directory, arguing over what permissions the directory and the socket file has.
  • The socket goes away when the last reference to the socekt is closed, removing the need to unlink it.

Downsides:

  • There is no access control, at all. Primarily relevant for the ControlPort, but that has separate mechanisms for restricting access.
  • Not wildly useful for sandboxes, since most sandboxing approaches will unshare/create a new IPC namespace.
  • Non-portable.

(0.2.0.3-alpha was the first time we supported AF_UNIX at all)

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#20337