Skip to content

GitLab

Trac
Trac

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Closed (moved)
Opened by Karsten Loesing@karsten

Investigate invalid descriptors in out/ and recent/ subdirectories

I just found more bad descriptors like the one mentioned in #20412 (moved) by looking through Onionoo logs. This might be a bigger problem than first thought.

I don't have the time to investigate this now, but it looks like we might not be flushing a buffer properly somewhere. For example:

hidden-@uploaded-at 2016-10-19 06:53:16

The hidden- part still belongs to the previous descriptor and then we start writing @uploaded-at 2016-10-19 06:53:16 as the first line of the next descriptor. Note that we wouldn't include that line under normal circumstances. How does it get there?

I'll attach four files from CollecTor's recent/ subdirectory which would otherwise be deleted soon.

I'm afraid we'll not only have to fix this bug but also go through the tarballs from the past months and see if those contain invalid descriptors. Hopefully it's a new bug.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information