Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #20764

Closed (moved)
(moved)
Open
Created Nov 25, 2016 by Trac@tracbot

Duplicate memset call in tor_addr_from_sockaddr

Hey folks,

I hope that you're all doing well and life is good!

When staring grumpily at bug https://trac.torproject.org/projects/tor/ticket/20716 I noticed that memset(addr, 0,...) is called on the address in tor_addr_from_sockaddr and then again in either tor_addr_from_ipv4n, tor_addr_from_ipv6_bytes, tor_addr_make_af_unix or tor_addr_make_unspec.

The attached removes the memset call from tor_addr_from_sockaddr.

Thanks in advance for perusal :)

Trac:
Username: icanhasaccount

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking