Skip to content

GitLab

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Closed (moved)
Opened by Nick Mathewson@nickm🐭

Crash while checking whether directory_crashes_dir_info()

rransom found this while testing his patch for bug988. Here's the stack trace:

09:47 < rransom> #0  get_net_param_from_list (net_params=0xb0b0b0b0b0b0b0b, para
m_name=0x4d8880 "refuseunknownexits", default_val=1) at networkstatus.c:2127
09:51 < rransom> #1  0x00000000004959ec in directory_caches_dir_info (options=0x1a66790) at dirserv.c:1217
09:51 < rransom> #2  0x0000000000410b20 in networkstatus_set_current_consensus (consensus=<value optimized out>, flavor=<value optimized out>, flags=<value optimized out>) at networkstatus.c:1734

So set_current_consensus frees the current_consensus, then calls directory_caches_dir_info, which indirectly calls get_net_param_for_list on current_consensus, which has been freed.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information