Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #21119

Closed (moved)
(moved)
Open
Created Jan 02, 2017 by Nick Mathewson@nickm🍬

Deprecate and replace type_getarray_val()

In the first version of the introduce1 branch, the type_getarray_val() accessor was used erroneously in a way that could have resulted in a buffer overflow.

That bodes ill for its usability. And since Trunnel is supposed to make it hard for us to make mistakes, we should consider fixing this.

Brainstorming replacement ideas:

  • type_copyinto_val(object, input, input_len);
  • type_copyfrom_val(object, target, target_len);
  • type_getarray_checked(object, array, need_len);
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking