Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #21150

Closed (moved)
Open
Opened Jan 05, 2017 by Roger Dingledine@arma

HiddenServiceStatistics gets set to 0 in your torrc, and stays 0 when you become a relay

HiddenServiceStatistics defaults to 1:

  V(HiddenServiceStatistics,     BOOL,     "1"),

but if you're not a public relay, it gets set to 0 on startup:

    if (!public_server_mode(options)) {
      options->CellStatistics = 0;
      options->EntryStatistics = 0;
      options->ConnDirectionStatistics = 0;
      options->HiddenServiceStatistics = 0;
      options->ExitPortStatistics = 0;
    }

and then when you saveconf, it doesn't match the default so you get a new line in your torrc file:

HiddenServiceStatistics 0

And then later if you run your Tor as a relay, it looks at the torrc file and decides not to collect or report hiddenservicestatistics, which is bad because that's supposed to be the default.

I think the fix is that we need an internal variable which reflects what we've decided to do, and we need to stop modifying the config option in place.

The same issue happened in #4244 (moved), and I think we have some other recent tickets to make this change for other config options.

This ticket would resolve #17909 (moved) as well.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.3.0.x-final
Milestone
Tor: 0.3.0.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#21150