Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #21175

Closed (moved)
(moved)
Open
Created Jan 09, 2017 by David Fifield@dcf

Line breaks separate checkboxes from labels in userstats-bridge-transport.html

The checkboxes and labels wrap such that the checkbox sometimes is left at the end of a line, separated from its label:

transport-wrap.png

This is the way it's currently formatted in website/web/WEB-INF/graph.jsp:

<input type="checkbox" name="transport" value="${row[0]}" id="transport_${row[0]}"${row[1]}>
<label class="checkbox-label" for="transport_${row[0]}">${row[2]}</label>

I did some experiments in the DOM editor and this fixes the problem and looks good with the current CSS (make input a child of label rather than use a for attribute):

<label class="checkbox-label">
  <input type="checkbox" name="transport" value="${row[0]}" id="transport_${row[0]}"${row[1]}> ${row[2]}
</label>

(Actually, the percentile checkboxes already work that way:)

<label class="checkbox-label">
  <input type="checkbox" name="n" value="${row[0]}"${row[1]}> ${row[0]}
</label>
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking