Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #21494

Closed (moved)
Open
Opened Feb 18, 2017 by teor@teor

Fix scan-build warnings about assigning to char**

scan-build complains about: tor_check_port_forwarding:

const char **argv; /* cli arguments */
...
argv = tor_calloc(args_n, sizeof(char *));

and: process_environment_make:

process_environment_t *env = tor_malloc_zero(sizeof(process_environment_t));
...
env->unixoid_environment_block = tor_calloc(n_env_vars + 1, sizeof(char *));

This is fine, and maybe there's a cast or magic comment we could use to make the warnings go away.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#21494