Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #21507
Closed (moved) (moved)
Open
Created Feb 19, 2017 by teor@teor

Reject Tor versions that contain non-numeric prefixes

In #21450 (moved), we made tor_version_parse use:

tor_parse_uint64(... , 10, 0, INT32_MAX, ...);

But this still allows versions that start with: an arbitrary amount of white space (as determined by isspace(3)) followed by a single optional "+" or "-" sign

This doesn't fit the version spec, and we should fix it. This is an issue that's existed since we started parsing tor versions.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking