Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #21789

Closed (moved)
Open
Opened Mar 21, 2017 by teor@teor

Use cached address values more often

arma said in #20423 (moved):

Once we get this one in, we might in 0.3.0 consider changing many more of these calls to cache_only=1. In fact, if we leave check_descriptor_ipaddress_changed() calling resolve_my_address() once a minute, maybe we're all set and the whole of router_pick_published_address() can just look at the cached values? I didn't want to make an invasive change like that in 0.2.9 though, since there are probably edge cases we care about, e.g. where getinfo_helper_misc() calls router_pick_published_address() and we're not a relay so we've never called resolve_my_address() before that very moment.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#21789