Error pages are broken in TBB ff52 nightly with security slider being on "Medium" or "High"

Go to a non-existent website http://nonexisssstentwebsite.com/

Or go to a website that doesn't support HTTPS with HTTPS: https://mysite.com/ (the "Go Back" button works, and the "Advanced" one doesn't)

Trac:
Username: blockflare

added TorBrowserTeam201704R component::applications/tor browser ff52-esr owner::tbb-team priority::medium reporter::blockflare resolution::fixed severity::normal status::closed type::defect labels

Replying to blockflare:

Go to a non-existent website http://nonexisssstentwebsite.com/

Unable to connect
Firefox can’t establish a connection to the server at nonexisssstentwebsite.com.
...
Try Again

What is broken? "Firefox" instead of "Tor Browser"?

Or go to a website that doesn't support HTTPS with HTTPS: https://mysite.com/ (the "Go Back" button works, and the "Advanced" one doesn't) The same.

[04-07 11:20:20] Torbutton INFO: controlPort >> 650 STREAM 256 CLOSED 51 mysite.com:443 REASON=END REMOTE_REASON=CONNECTREFUSED

Trac:
Username: blockflare

Screenshot for broken error page

Trac:
Username: blockflare

Trac:
Username: blockflare

Screenshot of broken error page

Trac:
Username: blockflare

Replying to cypherpunks:

Replying to blockflare:

Go to a non-existent website http://nonexisssstentwebsite.com/ {{{ Unable to connect Firefox can’t establish a connection to the server at nonexisssstentwebsite.com. ... Try Again }}} What is broken? "Firefox" instead of "Tor Browser"?

Not what I had in mind, through that's a good catch :)

Look at the screenshots I included. (Also this was tested on Debian 64)

Trac:
Username: blockflare

You see buttons from Secure connection error page. Of course, they are not actionable. This is a regression of esr52 fix for #8842 (moved). Confirmed with STR from that ticket.

blockflare: this does not happen with the security slider set to "low", right?

Trac:
Status: new to needs_information

Interestingly the error page is actually a different one with "low", huh.

Trac:
Keywords: N/A deleted, tbb-usability-website added

Replying to gk:

blockflare: this does not happen with the security slider set to "low", right?

Yes, only Medium and High are affected.

Trac:
Username: blockflare

Trac:
Summary: Error pages are broken in TBB ff52 nightly to Error pages are broken in TBB ff52 nightly with security slider not being on "Low"
Status: needs_information to assigned
Keywords: N/A deleted, tbb-security-slider added

Trac:
Summary: Error pages are broken in TBB ff52 nightly with security slider not being on "Low" to Error pages are broken in TBB ff52 nightly with security slider being on "Medium" or "High"

Allow JS on about:neterror?

Replying to cypherpunks:

Allow JS on about:neterror?

Indeed, adding about:neterror in the NoScript whitelist solves the problem in both Medium and High.

Trac:
Username: blockflare

bug_21887 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_21887&id=5d2f77c0c56a62199fab2034ba14686867808b82) has a small fixup to address this problem.

Trac:
Keywords: N/A deleted, TorBrowserTeam201704R added
Status: assigned to needs_review

Trac:
Cc: gk to gk, mcs, brade

r=mcs Looks good to me.

Thanks. Fixed with commit 5d2f77c0c56a62199fab2034ba14686867808b82 on master.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

Trac:
Keywords: tbb-security-slider, tbb-usability-website deleted, N/A added

closed

mentioned in issue #22025 (moved)

moved to tpo/applications/tor-browser#21887 (closed)