Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #22208

Closed (moved)
Open
Opened May 09, 2017 by Karsten Loesing@karsten

Provide lines containing extra, unrecognized arguments

This question came up when implementing #21934: do we need to include lines with extra arguments in Descriptor#getUnrecognizedLines()? Or do we need another method Descriptor#getPartiallyUnrecognizedLines()? Or can we safely drop those extra arguments on the floor? See also TorperfResults#getUnrecognizedKeys() which is somewhat related here, but not exactly the same.

This is not super urgent, because at least the bytes of the entire descriptor are available for further processing.

The fix is also not trivial to write, because we'll have manually go through all places where extra arguments are permitted and ignored and add those lines to a list of partially unrecognized lines.

The result could be that doing nothing is the way to go. Needs more thoughts.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
metrics-lib 3.0.0
Milestone
metrics-lib 3.0.0
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#22208