Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #22281
Closed (moved) (moved)
Open
Issue created May 16, 2017 by Nick Mathewson@nickm🐉

Prevent pattern of bugs caused by calling get_options() within options_validate() etc

In #22252 (moved) and elsewhere, we hit a problem with calling a function that called get_options() -- both directly and via networkstatus_get_latest_consensus() -- before the options were fully assigned.

We ought to do something to eliminate this pattern of bugs.

One possibility might be to 'fill in' the new options before they're completely validated. But we'd want to be able to roll back to the old options as needed if the new options didn't validate.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking