Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #22408

Closed (moved)
Open
Opened May 26, 2017 by Nick Mathewson@nickm🐭

Refactor functions over 300 lines long.

I think it's reasonable to impose a much smaller limit, but let's start by attacking the worst offenders. cc'ing catalyst because we've talked about this before.

It's probably a good idea to use a separate ticket or separate branch for each one.

300 connection_listener_new
306 networkstatus_set_current_consensus
327 rend_service_receive_introduction
330 ed_key_init_from_file
332 circuit_get_open_circ_or_launch
355 tor_spawn_background
360 router_dump_router_to_string
389 networkstatus_verify_bw_weights
389 parse_socks
399 connection_edge_process_relay_cell
404 circuit_expire_building
449 parse_port_config
535 options_act
541 connection_ap_handshake_rewrite_and_attach
548 router_parse_entry_from_string
638 networkstatus_parse_vote_from_string
973 networkstatus_compute_consensus
1269 options_validate
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#22408