Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #22565

Closed (moved)
(moved)
Open
Created Jun 11, 2017 by teor@teor

Refactor tor's signal handler to avoid undefined behaviour

A signal handler can be called at any time, including when Tor's data structures are in an inconsistent state.

The C standard says that setting anything other than a sig_atomic_t flag in a signal handler is undefined behaviour. POSIX is slightly more permissive, but we still do far too much in our signal handler.

Could we set flags and check them at the top of the event loop instead? Or are there things we must handle right away?

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking