Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #22670
Closed (moved) (moved)
Open
Issue created Jun 20, 2017 by Nick Mathewson@nickm🐉

Clean up warning behavior of decompression code in connection_dir_client_reached_eof()

There are several goofy things about the code that handles decompression in the above function.

First, when it decides to try two decompression methods, it logs failures from either one, even though it's only a big problem when they both fail.

Second, it treats a mismatched content-encoding as "info" when it should probably be "protocol_warn".

Third, it should be in its own function.

Fourth, the second call to warn_disallowed_anonymous_compression should probably only happen when we are about to call tor_uncompress() the second time.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking