Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #22746

Closed (moved)
Open
Opened Jun 28, 2017 by George Kadianakis@asn

CID 1413651: No retval check in ed25519_donna_blind_public_key()

/src/ext/ed25519/donna/ed25519_tor.c: 307 in ed25519_donna_blind_public_key()
301       ed25519_donna_gettweak(tweak, param);
302       expand256_modm(t, tweak, 32);
303     
304       /* No "ge25519_unpack", negate the public key. */
305       memcpy(pkcopy, inp, 32);
306       pkcopy[31] ^= (1<<7);
>>>     CID 1413651:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "ge25519_unpack_negative_vartime" without checking return value (as is done elsewhere 4 out of 5 times).
307       ge25519_unpack_negative_vartime(&A, pkcopy);
308     
309       /* A' = [tweak] * A + [0] * basepoint. */
310       ge25519_double_scalarmult_vartime(&Aprime, &A, t, zero);
311       ge25519_pack(out, &Aprime);
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.3.2.x-final
Milestone
Tor: 0.3.2.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#22746