Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #22779
Closed (moved) (moved)
Open
Issue created Jun 30, 2017 by teor@teor

choose_good_entry_server() is no longer used to choose entry guards

choose_good_entry_server() says:

 * If <b>state</b> is NULL, we're choosing a router to serve as an entry
 * guard, not for any particular circuit.

But in 0.3.0 and later, we use guardsets to choose entry guards. (And we use this function to choose individual entries.)

We should:

  • fix the comment,
  • check for NULL state (and do what?), and
  • make sure that guard selection and entry selection doesn't get out of sync. (I think we're ok here, but I don't understand the new guard code very well.)
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking