Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #23056

Closed (moved)
Open
Opened Jul 28, 2017 by David Goulet@dgoulet🐋

prop224: Intro point aren't transfered between services on HUP

For the current prop224 upstream code, the move_intro_points() function doesn't work as expected, actually it's very broken.

First of all, it is impossible to move intro points with the current condition because the newly created service (dst) doesn't have any descriptor. Thus, this if() is basically dead code and we never move intro points.

if (src->desc_current && dst->desc_current) {
  move_descriptor_intro_points(src->desc_current, dst->desc_current);
...

The fix is to move the descriptor(s) and not only the intro points because the service needs the descriptor signing key that cross certify every IP authentication key. So, we really need to move the full thing from one service to the other else we would have to re-sign everything.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.3.2.x-final
Milestone
Tor: 0.3.2.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#23056