Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #2313

Closed (moved)
Open
Opened Dec 24, 2010 by Sebastian Hahn@sebastian

pthreads on windows includes config.h

Attempting to compile Tor fails for me, because we use AM_CONFIG_HEADER(orconfig.h). This means that autofoo defines HAVE_CONFIG_H, and pthread.h attempts to include config.h when HAVE_CONFIG_H is defined.

There are a two solutions that I can see: We can just manually undefine HAVE_CONFIG_H (we don't use it anywhere), so that pthread won't include it. This doesn't seem to have negative side effects (orconfig.h is already included by our source anyways, so the definitions are available).

We could rename our config.[ch] files to something else and use config.h for the file generated during configure. This is a lot of work and doesn't mean a functional improvement that I can think of, so this is probably not what we want to do.

A third possible solution that I don't know how to make work is to stop configure from defining HAVE_CONFIG_H. Maybe that is easily possible and could be an alternative to the first idea.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#2313