GetTor should ignore quoted keywords in email replies that quote the help message

If I send an email with the subject "help" to GetTor, and then send an "blank reply that quotes the entire message, I get the links for OrBot for Android (presumably because that's the first recognized keyword in the quoted reply. It's not clear to me what a "blank" reply should produce in response to a help message, maybe a more detailed help message? If there is no more detailed help available, maybe don't mention the blank message option?

added anti-censorship-roadmap-2020Q1 component::applications/gettor owner::cohosh parent::9036 points::1 priority::medium resolution::fixed reviewer::phw severity::normal status::closed type::defect labels

Let #9036 (moved) adopt some children.

Trac:
Parent: N/A to #9036 (moved)

cc'ing cohosh on open GetTor tickets.

Trac:
Cc: N/A to cohosh

Removing ilv as onwer of many of the tickets. He can take back the ticket he will work on if he comes back into gettor.

Trac:
Status: new to assigned
Owner: ilv to N/A

Trac:
Status: assigned to new

Trac:
Points: N/A to 1

Trac:
Keywords: N/A deleted, anti-censorship-roadmap-2020Q1 added

Update of the current status:

Some things have changed with GetTor, so the behaviour described in the description is slightly different now. If you reply to the help email now, you will simply get another help email because GetTor recognizes the help keyword in the subject line Re: [GetTor] Help Email

We still want to parse the email subject, but we should prioritize parsing the body of the email first and ignore reply text.

We may also want to include some help text along with GetTor links, in a way similar to our bridgedb emails in #30941 (moved)

Trac:
Status: new to assigned
Owner: N/A to cohosh

Here's a commit that will ignore quoted text and prioritize the link command for GetTor, along with some tests: https://dip.torproject.org/cohosh/gettor/merge_requests/6

Trac:
Status: assigned to needs_review

Trac:
Reviewer: N/A to phw

I left a bunch of comments and questions in the PR.

FWIW, we recently fixed a similar issue (#17626 (moved)) in BridgeDB; also by ignoring quoted commands.

Trac:
Status: needs_review to needs_revision

Some popular email clients quote messages by top-posting, then including the original message after a header. (For example, Microsoft Outlook.)

This behaviour might also affect the BridgeDB changes in #17626 (moved).

Thanks! This feedback was useful. I added a few more test cases to capture the feedback from both phw and teor, as well as some fixes to the code.

Trac:
Status: needs_revision to needs_review

LGTM!

Trac:
Status: needs_review to merge_ready

Replying to teor:

Some popular email clients quote messages by top-posting, then including the original message after a header. (For example, Microsoft Outlook.)

This behaviour might also affect the BridgeDB changes in #17626 (moved).

Good point but this shouldn't affect BridgeDB's email parser.

Merged at f31e18f0

Deployed to gettor-01

2020-03-12T17:18:05+0000 [gettor#info] Starting services.

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed

closed

changed time estimate to 8h

mentioned in issue #23226 (moved)

moved to tpo/anti-censorship/gettor-project/trac#23225 (closed)