test: test_options_validate__outbound_addresses is broken
Turns out that test_options_validate__outbound_addresses() tries to test a bad OutboundBindAddress option and thus expects options_validate() to return -1.
However, in options_validate():
if (parse_outbound_addresses(options, 1, msg) < 0)
return -1;
... but if you look at parse_outbound_addresses() it ONLY returns 0 so it's simply not working. Was added in with commit 81c78ec7556 which is tor-0.3.0.3-alpha.
options_act() also calls parse_outbound_addresses() in the same way.