Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #23467

Closed (moved)
Open
Opened Sep 11, 2017 by cypherpunks@cypherpunks

running parameter vs. field mismatch

https://lists.torproject.org/pipermail/metrics-team/2017-September/000456.html

It might be that we're using two different definitions for "running":

 - The "running=false" parameter checks whether a bridge is contained in
the latest known status *and* has the "Running" flag assigned.

https://gitweb.torproject.org/onionoo.git/tree/src/main/java/org/torproject/onionoo/writer/SummaryDocumentWriter.java#n83

 - The "running" field in details documents only checks whether a bridge
is contained in the latest known status but ignores whether it got the
"Running" flag there or not.

https://gitweb.torproject.org/onionoo.git/tree/src/main/java/org/torproject/onionoo/updater/NodeDetailsStatusUpdater.java#n866

We should probably use the first definition and also require the
"Running" flag before calling a bridge "running".
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Onionoo-1.6.0
Milestone
Onionoo-1.6.0
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#23467