Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #23532

Closed (moved)
Open
Created Sep 15, 2017 by Taylor Yu@catalyst

NETINFO clock skew detection doesn't work on clients

The NETINFO clock skew detection code in channel_tls_process_netinfo_cell() doesn't work for clients because of an apparently unnecessary call to router_get_by_id_digest(), which will generally return NULL on clients (which generally download only microdescriptors therefore won't populate the routerlist). This NULL return prevented the clock skew reporting code from running. Thanks to arma for pointing this out on IRC. Fixing this would help bootstrap fail more quickly in some clock skew situations.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.3.2.x-final
Milestone
Tor: 0.3.2.x-final
Assign milestone
Time tracking
None
Due date
None