Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #23588

Closed (moved)
Open
Opened Sep 20, 2017 by teor@teor

Write fascist_firewall_choose_address_ls() and use it in hs_get_extend_info_from_lspecs()

Currently, the address choice logic is:

  • if we have an IPv6 address and can reach the ls IPv6 address, and prefer IPv6, use it
  • if we have an IPv4 address and can reach the ls IPv4 address, use it

But it needs to be:

  • if we have both addresses and can reach both, then use whatever we prefer
  • if we have one address and can reach it, use it

This doesn't matter until clients put IPv6 addresses in the link specifier.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.4.1.x-final
Milestone
Tor: 0.4.1.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#23588