Skip to content

GitLab

Trac
Trac

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Closed (moved)
Opened by Damian Johnson@atagar

"GETINFO config-text" adds spurious DataDirectory, Log entries

Repro steps:

  • use a blank torrc (just setting the ControlPort)
  • run tor
  • issue a GETINFO get-text

result: it provides a 'Log notice stdout' entry expected: we should only get back entries that differ from their defaults (in this case only the ControlPort)

from irc: 15:03 < armadev> atagar: it is a tor bug, i believe. i just reproduced. 15:03 < atagar> ok, I'll file a ticket - thanks :) 15:04 < armadev> if (smartlist_len(elts) == 0) 15:04 < armadev> smartlist_add(elts, tor_strdup("stdout")); 15:04 < armadev> in options_init_logs() 15:04 < armadev> that's where it comes from. we add it if there are no other logs. 15:04 < armadev> hmmmm. no, i take that back. 15:05 < armadev> /* Special case on first boot if no Log options are given. */ 15:05 < armadev> if (!options->Logs && !options->RunAsDaemon && !from_setconf) 15:05 < armadev> config_line_append(&options->Logs, "Log", "notice stdout"); 15:05 < armadev> there we go.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information