control: HS_DESC event failed upload sends back the wrong Action

When a descriptor upload fails, tor sends on the control port a UPLOAD_FAILED event where in fact it should be sending a FAILED event as the action with the reason: UPLOAD_REJECTED or UNEXPECTED.

The control_event_hs_descriptor_upload_failed() is the offending function.

The control spec does not specify at all the Action=UPLOAD_FAILED nor Stem for instance knows about it so this is a problem on tor side.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information