Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #24456

Closed (moved)
Open
Opened Nov 28, 2017 by George Kadianakis@asn

Figure out what to do with the guardfraction feature

Guardfraction code is still around the codebase: guard_get_guardfraction_bandwidth(), should_apply_guardfraction(), routerstatus_parse_guardfraction(), guardfraction_line_apply(), guardfraction_file_parse_guard_line(), dirserv_read_guardfraction_file_from_str(), compute_weighted_bandwidths(). Also AFAIK some dirauths are still running the guardfraction python script.

Unfortunately, guardfraction code is still broken because of #16255 (moved) and possibly other unknown bugs. Hence, guardfraction support is disabled in the dirauths and all that code is currently useless.

My current plan here is to remove the guardfraction code from the Tor codebase, since fixing it and maintaining it as a PITA that I don't want to sign up for and we probably don't need it as much as we thought we did (see comment:36:ticket:16255).

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#24456